ContentPane: potential to double-parse when setting value to a widget instance

[Kenneth G. Franqueiro]

If parseOnLoad is true on a dijit.layout.ContentPane instance and you set its value to a widget instance, the parser will still attempt to run on the content of the passed widget's DOM node. If the passed widget happens to have been a templated widget containing non-templated widgets, some nodes may still have lingering dojoTypes which the parser will then incorrectly attempt to instantiate into widgets, potentially causing id errors.

[Kenneth G. Franqueiro]

simple test that will produce an error due to conflicting id to demonstrate the problem. This example is simplistic and contrived but it's certainly probable for someone to have a ContentPane? that contains a non-templated widget (layout or otherwise) within.

[Kenneth G. Franqueiro]

simple fix that will only parse if parseOnLoad is true *and* the passed content is *not* already a widget.

[Kenneth G. Franqueiro]

Forgot to mark the version correctly. Actually this happens even further back than 1.5, but just to be clear, it's *not* a 1.6 regression.

[bill]

The fix looks fine to me but you need to add an automated test case (probably in ContentPane.html). Not sure if we have any tests for passing in a widget to set("content", ... ) , or as a parameter to the constructor. We should though.

[Kenneth G. Franqueiro]

Patch to add test to ContentPane.html

[Kenneth G. Franqueiro]

Making test moar betterer

[bill]

Looks good to me, feel free to check in after the 1.6 freeze.

[Kenneth G. Franqueiro]

(In [23950]) Add check to ContentPane? to ensure parser is not run if content is set to a widget; tests included. Fixes #12348