Opened 9 years ago

Last modified 3 years ago

#12346 assigned defect

missing node on overlay after _handleSend()

Reported by: goriol Owned by: dylan
Priority: high Milestone: 1.15
Component: DojoX Form Version: 1.6.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description

dojox.form.FileInputAuto?._handleSend() removes this.overlay.firstChild (that was previously changed to display the upload message) but never restores the original blank text node (" ). Thus, when _sendFile() is invoked another time (if an error occurred at first attempt), it will fail trying to remove a missing node.

I would suggest to change:

	_handleSend: function(data,ioArgs){
		// summary: The callback to toggle the progressbar, and fire the user-defined callback

		// innerHTML throws errors in IE! so use DOM manipulation instead
		this.overlay.removeChild(this.overlay.firstChild);

		// ...
	},

into:

	_handleSend: function(data,ioArgs){
		// summary: The callback to toggle the progressbar, and fire the user-defined callback

		// innerHTML throws errors in IE! so use DOM manipulation instead
		this.overlay.removeChild(this.overlay.firstChild);
		this.overlay.appendChild(document.createTextNode(" "));

		// ...
	},

Change History (2)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.12
Owner: changed from dante to dylan
Status: newassigned

comment:2 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.