Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12341 closed defect (fixed)

"set readOnly" button in test_SimpleTextArea.html broken

Reported by: bill Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description

The "set readonly" button in test_SimpleTextArea.html doesn't do anything, mainly because of a typo in the test file where it specifies false instead of true.

But also:

  1. we are missing automated tests for readOnly
  2. _FormWidget.js unnecessarily adds readOnly to attributeMap, even though there is a custom setter
  3. the custom setter calls dojo.attr(this.focusNode, 'readOnly', value), with a capital O, rather than dojo.attr(this.focusNode, 'readonly', value), is that right?

Change History (3)

comment:1 Changed 8 years ago by Douglas Hays

Milestone: tbd1.7
Status: newassigned

comment:2 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [24127]) Fixes #12341. Fix test button to set readOnly instead of remove it. Verified readOnly is correct and not readonly. attributeMap already fixed. TextBox? tests already test readOnly extensively and SimpleTextArea? inherits from there.

comment:3 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.