Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12340 closed defect (fixed)

IE9: dojo.query improperly handles attribute selectors

Reported by: Kenneth G. Franqueiro Owned by: anonymous
Priority: high Milestone: 1.5.2
Component: General Version: 1.6.0rc1
Keywords: ie9 Cc:
Blocked By: Blocking:

Description

This problem and the solution was pointed out and isolated by the MSIE team, so hats off to them.

dojo.query currently fails to properly match attribute selectors. This is another instance of an isIE code branch that no longer needs to be handled specially for IE9.

This is observable in the form of 1 failure followed by 2 errors in tests/_base/query.html if you force IE9 into standards mode (since the page throws it to quirks by default).

Attachments (1)

12340.diff (413 bytes) - added by Kenneth G. Franqueiro 8 years ago.
Patch, based on IE team's findings.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Kenneth G. Franqueiro

Attachment: 12340.diff added

Patch, based on IE team's findings.

comment:1 Changed 8 years ago by Kenneth G. Franqueiro

Does this require a CCLA from the MSIE devs to commit? They didn't give the patch verbatim, but they pointed out the precise fork in the code and recommended taking the "non-IE" branch for IE9.

comment:2 Changed 8 years ago by bill

No, we don't need CLA's for one line fixes.

comment:3 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: newclosed

(In [23870]) Revise codepath for defaultGetter for IE9. Fixes #12340 !strict

comment:4 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: 1.61.5.2

Updating milestone to 1.5.2 to reflect inclusion in changeset [26956] for ticket #14199.

Note: See TracTickets for help on using tickets.