Opened 9 years ago
Closed 9 years ago
#12339 closed defect (fixed)
Dojo base fails to initialize if Object prototype has been augmented
| Reported by: | Kenneth G. Franqueiro | Owned by: | Eugene Lazutkin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.6 |
| Component: | Core | Version: | 1.5 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
There is an unprotected for...in loop in _base/html.js which causes dojo to fail to load in environments where some script has naughtily added enumerable members to Object.prototype.
I heard from dante that "Object.prototype is verboten", so I'm not sure what you all will think of adding the if-hasOwnProperty check necessary to resolve it, but this seems to be the one thing that snags dojo base from loading successfully in this case, and we do seem to check hasOwnProperty in other places in base.
Attachments (2)
Change History (5)
Changed 9 years ago by
| Attachment: | 12339.diff added |
|---|
comment:1 Changed 9 years ago by
| Milestone: | tbd → future |
|---|---|
| Owner: | changed from anonymous to Eugene Lazutkin |
| Status: | new → assigned |
comment:2 Changed 9 years ago by
| Milestone: | future → 1.6 |
|---|
comment:3 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
fix by adding hasOwnProperty check.