Opened 10 years ago

Closed 10 years ago

#12321 closed defect (fixed)

[patch][ccla]ScrollableView may Prevent Onclick Handler of IconItem

Reported by: ykami Owned by: ykami
Priority: high Milestone: 1.6.1
Component: DojoX Mobile Version: 1.6.0b1
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

This problem happens when IconContainer is placed on ScrollableView. If you click on an IconItem with a little movement, it doesn't open. It looks ScrollableView prevents IconItem's onclick events.

Attachments (1)

12321.patch (695 bytes) - added by ykami 10 years ago.
patch for review

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by ykami

In my experiment, the problem happens mainly on desktop browsers. It was not bad on iPhone. But we should have a drag start threshold. I'm attaching a patch that exposes the threshold property. I gave the default value as 0 (pixel) and didn't change the current behavior to minimize any side-effect risk. User applications can give, for example, 10 pixels to ScrollableView as below. Then drag does not start until you move more than 10 pixels, and thus the icon click operation becomes easier.

<div dojoType="dojox.mobile.ScrollableView" threshold="10">

Changed 10 years ago by ykami

Attachment: 12321.patch added

patch for review

comment:2 Changed 10 years ago by Chris Mitchell

Keywords: 1.7-mobile added

comment:3 Changed 10 years ago by Chris Mitchell

Summary: ScrollableView may Prevent Onclick Handler of IconItem[patch][ccla]ScrollableView may Prevent Onclick Handler of IconItem

comment:4 Changed 10 years ago by Chris Mitchell

Milestone: tbd1.7

comment:5 Changed 10 years ago by Chris Mitchell

Owner: changed from Shane O'Sullivan to ykami

comment:6 Changed 10 years ago by ykami

(In [24046]) Refs #12321 !strict. Added the threshold property

comment:7 Changed 10 years ago by ykami

(In [24047]) Refs #12321 !strict. Added the threshold property

comment:8 Changed 10 years ago by ykami

Milestone: 1.71.6.1
Resolution: fixed
Status: newclosed

Applied the patch to the trunk and the 1.6 branch.

Note: See TracTickets for help on using tickets.