Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12319 closed defect (fixed)

sniff is missing from dojox.mobile

Reported by: ykami Owned by: Shane O'Sullivan
Priority: high Milestone: 1.6
Component: DojoX Mobile Version: 1.6.0b1
Keywords: Cc: bill
Blocked By: Blocking:

Description

dijit._base.sniff doesn't work for dojox.mobile applications. Browser specific class names such as dj_webkit are not given to <html>, and thus causes rendering problems.

Attachments (2)

12319.patch​ (392 bytes) - added by ykami 8 years ago.
patch for review
12319-revised.patch​ (3.4 KB) - added by ykami 8 years ago.
patch for review

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by ykami

After [23762], dijit base can no longer be loaded automatically. Need to add explicit dojo.require("dijit._base.sniff").

Changed 8 years ago by ykami

Attachment: 12319.patch​ added

patch for review

comment:2 Changed 8 years ago by ykami

Fixing iphone.css and android.css was much better than to force requiring dijit._base.sniff. Anyway the compatibility module needs uacss, so the revised patch adds dojo.require("dijit._base.sniff") to compat.js instead of _base.js, and modifies the css files a little. Please do not use 12319.patch.

Changed 8 years ago by ykami

Attachment: 12319-revised.patch​ added

patch for review

comment:3 Changed 8 years ago by bill

Milestone: tbd → 1.6

comment:4 Changed 8 years ago by bill

Resolution: → fixed
Status: new → closed

(In [23824]) Remove dijit.base_sniff dependency except for (desktop browser) compatibility mode, refs #12274, fixes #12319 !strict.

comment:5 Changed 8 years ago by bill

(In [23829]) Forgot to remove dijit.base_sniff dependency for iPad, refs #12274, fixes #12319 !strict.

Note: See TracTickets for help on using tickets.