Opened 8 years ago

Closed 8 years ago

#12318 closed defect (fixed)

[patch][ccla] Icon Pane will Not Appear for the 2nd Time inside ScrollableView

Reported by: ykami Owned by: ykami
Priority: high Milestone: 1.6.1
Component: DojoX Mobile Version: 1.6.0b1
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

A basic functionality of IconItem is that when you click the icon, a pane will appear. You can click the close icon on the left upper corner of the pane to close it. After do that, you can display the pane by clicking the icon again. However, if the icon is inside a ScrollableView, you can only display the pane for the first time. Please see the attached video. If you change from ScrollableView to View, everything is fine. This bug is a little bit severe since ScrollableView is widely used.

Attachments (1)

12318.patch​ (830 bytes) - added by ykami 8 years ago.
patch for review

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by ykami

If you use ScrollableView, webkitAnimationStart/End handlers are added twice. One is from scrollable.js, the other is from View. The former connects to containerNode, the latter connects to domNode. For some reason, in this case, webkitAnimationStart/End fire only for containerNode, not for domNode. A solution is to always connect to domNode.

Changed 8 years ago by ykami

Attachment: 12318.patch​ added

patch for review

comment:2 Changed 8 years ago by Chris Mitchell

Keywords: 1.7-mobile added

comment:3 Changed 8 years ago by Chris Mitchell

Summary: Icon Pane will Not Appear for the 2nd Time inside ScrollableView → [patch][ccla] Icon Pane will Not Appear for the 2nd Time inside ScrollableView

comment:4 Changed 8 years ago by Chris Mitchell

Milestone: tbd → 1.7

comment:5 Changed 8 years ago by Chris Mitchell

Owner: changed from Shane O'Sullivan to ykami

comment:6 Changed 8 years ago by ykami

(In [24044]) Refs #12318 !strict. Changed the connection target from containerNode to domNode

comment:7 Changed 8 years ago by ykami

(In [24045]) Refs #12318 !strict. Changed the connection target from containerNode to domNode

comment:8 Changed 8 years ago by ykami

Milestone: 1.7 → 1.6.1
Resolution: → fixed
Status: new → closed

Applied the patch to the trunk and the 1.6 branch.

Note: See TracTickets for help on using tickets.