Opened 8 years ago
Closed 8 years ago
#12302 closed defect (fixed)
doh fails to run under rhino
| Reported by: | Sam Foster | Owned by: | Sam Foster |
|---|---|---|---|
| Priority: | high | Milestone: | 1.6 |
| Component: | TestFramework | Version: | 1.6.0b1 |
| Keywords: | Cc: | Adam Peller | |
| Blocked By: | Blocking: |
Description (last modified by )
Running:
./runner.sh dojoUrl=../../dojo/dojo.js
results in:
An exception occurred: TypeError: Cannot find function indexOf in object [object Object].
..it appears the option parsing is failing as the script arguments are not being passed through properly. I'm attaching a patch that corrects this in rhino (and does not regress in the browser)
Attachments (2)
Change History (8)
Changed 8 years ago by
comment:1 Changed 8 years ago by
| Cc: | Adam Peller added |
|---|
comment:3 Changed 8 years ago by
Sorry I was a dofus and attached the wrong file...See runner.js.scriptArgs.patch Can you reproduce the problem without the patch? Im a bit mystified as to how this broke, or perhaps how it worked in the first place?
comment:4 Changed 8 years ago by
| Milestone: | tbd → 1.6 |
|---|---|
| Owner: | changed from alex to Kris Zyp |
Regressed in [23035] The function wrapper is new and apparently prevents arguments from being visible. Kris, can you take a look at Sam's patch?
Changed 8 years ago by
| Attachment: | runner.js.scriptArgs.patch added |
|---|
[CLA] [PATCH] Updated patch: Fixed script argument passing in runner.js
comment:5 Changed 8 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | changed from Kris Zyp to Sam Foster |
I've updated the patch as it was being reported as out of date? Apply the patch to runner.js makes ./runner.sh work again for me. (There's a ton of test failures and exceptions, but that's a different story)
comment:6 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
[CLA] [PATCH] Fixed script argument passing in runner.js