Opened 14 years ago

Closed 14 years ago

#123 closed defect (fixed)

dnd is broken in Opera (text gets selected on drag)

Reported by: eugene@… Owned by: anonymous
Priority: high Milestone:
Component: General Version: 0.1
Keywords: Cc:
Blocked By: Blocking:

Description

This patch enables drag-n-drop for Opera. Tested with Opera 8.50.

Attachments (1)

dojo.dnd.2.patch​ (2.2 KB) - added by eugene@… 14 years ago.
this patch fixes dnd files

Download all attachments as: .zip

Change History (9)

Changed 14 years ago by eugene@…

Attachment: dojo.dnd.2.patch​ added

this patch fixes dnd files

comment:1 Changed 14 years ago by eugene@…

These fixes are similar to #122. I tested the code using Opera 8.50, IE6, FF 1.4.

comment:2 Changed 14 years ago by psowden

Resolution: → fixed
Status: new → closed

(In [1609]) applying (modified) patch to fix drag and drop in Opera. fixes #122 and fixes #123

comment:3 Changed 14 years ago by eugene@…

I agree that enabling e.preventDefault() on mouse down event is bad. But without it drag operations produce chaotic selection in Opera. I'll try to investigate how to deal with it.

BTW, one possible (and completely safe) solution is to have drag handles. It looks like that was the original idea (API is there) but no code to support it whatsoever.

comment:4 Changed 14 years ago by psowden

Resolution: fixed
Status: closed → reopened
Summary: [patch] dnd fix for Opera browsers → dnd is broken in Opera (text gets selected on drag)

I'll reopen this bug to track this issue.

comment:5 Changed 14 years ago by eugene@…

I enabled e.preventDefault() to see what breaks and I don't see any problems. I tested Opera 8.50, IE6, FF:

  1. I can click links in drag sources without problems.
  2. I cannot select text in drag sources --- it causes dragging.

I think it's how it's supposed to be. Could you verify that? If you see any unwanted side-effects, please tell me, so I can look for them and fix 'em.

comment:6 Changed 14 years ago by eugene@…

Priority: normal → high

comment:7 Changed 14 years ago by eugene@…

Priority: high → normal

sorry

comment:8 Changed 14 years ago by psowden

Resolution: → fixed
Status: reopened → closed

This has been fixed by renabling e.preventDefault on mouss down over drag sources. This can present some undesirable behaviour for complex drag sources, for example if they contain text that should be selectable.

Marking as fixed for now, by [1667]

Note: See TracTickets for help on using tickets.