Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12299 closed defect (fixed)

TooltipDialog: preload=true and preload=false both not working

Reported by: Caleb Maclennan Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit Version: 1.6.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Using declarative markup to create a dijit.form.DropDownButton with an attatched dijit.TooltipDialog and seting the href properly works to load the contents using an xhr request, but setting the preload property to true has no effect. The xhr request does not fire until the drop down button is activated.

Dojo version 1.6.0b2.

Attachments (3)

TooltipDialogHref.html (1.2 KB) - added by bill 8 years ago.
Working test case for TooltipDialog? with an href and preload=true. You can see that it's working because on page load it gets an error about ComboBox? being undefined. The ComboBox? reference is in the href'd page. Put test case in dijit/tests.
TooltipDialogHref_failspreload.html (1.3 KB) - added by Caleb Maclennan 8 years ago.
Test case that fails to preload content of href for tooltip
TooltipDialogHref_failsstopreload.html (1.2 KB) - added by Caleb Maclennan 8 years ago.
Test case that demonstrates failure to obey preload=false for href in tooltipdialog

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by bill

Description: modified (diff)
Resolution: worksforme
Status: newclosed

It works for me, please attach a test case next time you file a ticket. I'll attach my test case which is working.

Changed 8 years ago by bill

Attachment: TooltipDialogHref.html added

Working test case for TooltipDialog? with an href and preload=true. You can see that it's working because on page load it gets an error about ComboBox? being undefined. The ComboBox? reference is in the href'd page. Put test case in dijit/tests.

comment:2 Changed 8 years ago by Caleb Maclennan

Using current trunk dojo, your test case works, mine still fails. Working on cleaning it up to upload.

However: Your test case fails the oposite direction, even if you set preload to false, it still preloads.

Changed 8 years ago by Caleb Maclennan

Test case that fails to preload content of href for tooltip

Changed 8 years ago by Caleb Maclennan

Test case that demonstrates failure to obey preload=false for href in tooltipdialog

comment:3 Changed 8 years ago by Caleb Maclennan

Resolution: worksforme
Status: closedreopened

I just uploaded two test cases for you.

One is identical to yours except I set preload=false to show that it is not obeying the directive. Your test case always preloads.

The other I changed to put the test button inside another dijit.layout.ContentPane?. Adding this layer of nesting causes the preload to fail to fire.

comment:4 Changed 8 years ago by bill

Owner: set to bill
Status: reopenednew
Summary: preload=true not working on dijit.TooltipDialog inside dijit.form.DropDownButtonTooltipDialog: preload=true and preload=false both not working

OK, thanks for the test cases, I'll check in a fix now, try it out to make sure that it works for you.

comment:5 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

(In [23813]) Fixes for TooltipDialog to obey preload=true/false setting, fixes #12299 !strict.

comment:6 Changed 8 years ago by bill

(In [23858]) Fix spurious test failure when run from runTests.html, doh.Deferred.callback() must be passed a parameter. Refs #12299.

comment:7 Changed 8 years ago by bill

(In [23860]) Apparently on IE an element with no parent set has a parent of the document itself, so avoid thinking that the element has a parent, and a null pointer exception. Refs #12299 !strict.

Note: See TracTickets for help on using tickets.