Select: _addOptionForItem() in dijit.form._FormSelectWidget uses wrong callback in store.loadItem()

[Adam Gould]

When calling store.loadItem(), _addOptionForItem is passing an "onComplete" callback. This callback doesn't exist for loadItem(). It should be "onItem".

[Adam Gould]

Patch against 1.5 to substitute the correct callback

[bill]

Sounds like we are also missing a unit test for that method (or rather, the public API that uses that method).

[Douglas Hays]

Clearly it should be onItem, but how do I trigger the if(!store.isItemLoaded(item)) code path in an automated test?

[Douglas Hays]

(In [24841]) Fixes #12295. Change onComplete to onItem as the attribute to loadItem. Needs an automated test but getting isItemLoaded to return false seems fleeting. !strict

[bill]

You can see some examples where isItemLoaded(item) returns false in tests/tree/node1.1. It contains "partially loaded" items, ex::

{ $ref: 'node1.1.1', name: 'node1.1.1'}

(node1.1 is a data file for JsonRestStore, not ItemFileReadStore.)

Maybe it's not worth testing though, the idea of partially loaded items goes away with the new dojo.store API.