[patch][ccla] Charting Widget without fill/stroke specified will not use the theme fill/stroke for chart backgroud

[cjolif]

See the attached test case, if you do not specify fill/stroke on Chart widget it does not use the theme chart fill instead. If you use the Chart core component it works.

The candidate patch is making sure the behavior is consistent against the widget and the core component.

That is:

• no value is specified the theme is used

• null is specified nothing is drawn

• a color is specified, it is used to draw

[cjolif]

Component: General is wrong, this is of course a charting issue. Can't find a way to edit this.

[Adam Peller]

There appears to be a typo in the patch (a stray 'f') Also, I think there's special syntax to declare variables for the parser but not actually include them in the code, something like /*===== =====*/

[Adam Peller]

is there something missing from the patch?

[cjolif]

I have fixed the typo. For the special syntax, I will try to find about it and come back to you.

[cjolif]

Can't find anything about the /*===== =====*/ syntax.

@peller is there something missing from the patch?

Are your referring to something in particular? From my point of view nothing is missing except if we want to use the above syntax.

[Adam Peller]

oh, it's as simple as not defining those vars to null. Got it.

I don't think the special syntax is documented. Anyway, Eugene ought to be able to take it from here. Thanks, Christophe!

[cjolif]

Yes, that's exactly just defining the variables was causing trouble because the charting code is testing against undefined later down the road. Thanks noticing the typo!

[cjolif]

Not that this patch also fix clipping issues with charting widget. Indeed the clipping is done by the chart fill and without this patch the chart fill of the theme will be overridden by the null value of the widget preventing clipping to happen.

[Eugene Lazutkin]

Again: all is fine and dandy, but no change set.

[bill]

[24420] and [24430] (from Chris again)