#12290 closed defect (fixed)
[patch][ccla] Charting Widget without fill/stroke specified will not use the theme fill/stroke for chart backgroud
Reported by: | cjolif | Owned by: | Chris Mitchell |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Charting | Version: | 1.6.0b1 |
Keywords: | 1.7-mobile | Cc: | Chris Mitchell |
Blocked By: | Blocking: |
Description
See the attached test case, if you do not specify fill/stroke on Chart widget it does not use the theme chart fill instead. If you use the Chart core component it works.
The candidate patch is making sure the behavior is consistent against the widget and the core component.
That is:
- no value is specified the theme is used
- null is specified nothing is drawn
- a color is specified, it is used to draw
Attachments (2)
Change History (18)
Changed 10 years ago by
Attachment: | test_fillstroke.html added |
---|
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Component: | General → Charting |
---|---|
Owner: | changed from anonymous to Eugene Lazutkin |
There appears to be a typo in the patch (a stray 'f') Also, I think there's special syntax to declare variables for the parser but not actually include them in the code, something like /*===== =====*/
comment:4 Changed 10 years ago by
I have fixed the typo. For the special syntax, I will try to find about it and come back to you.
Changed 10 years ago by
Attachment: | Chart.patch added |
---|
comment:5 Changed 10 years ago by
Can't find anything about the /*===== =====*/ syntax.
@peller is there something missing from the patch?
Are your referring to something in particular? From my point of view nothing is missing except if we want to use the above syntax.
comment:6 Changed 10 years ago by
oh, it's as simple as not defining those vars to null. Got it.
I don't think the special syntax is documented. Anyway, Eugene ought to be able to take it from here. Thanks, Christophe!
comment:7 Changed 10 years ago by
Yes, that's exactly just defining the variables was causing trouble because the charting code is testing against undefined later down the road. Thanks noticing the typo!
comment:8 Changed 10 years ago by
Keywords: | 1.7-mobile added |
---|
comment:9 Changed 10 years ago by
Milestone: | tbd → 1.7 |
---|
comment:10 Changed 10 years ago by
Not that this patch also fix clipping issues with charting widget. Indeed the clipping is done by the chart fill and without this patch the chart fill of the theme will be overridden by the null value of the widget preventing clipping to happen.
comment:11 Changed 10 years ago by
Owner: | changed from Eugene Lazutkin to Chris Mitchell |
---|---|
Status: | new → assigned |
comment:12 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:13 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:14 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Component: General is wrong, this is of course a charting issue. Can't find a way to edit this.