Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#12274 closed task (fixed)

_Widget: split into _WidgetBase and _Widget

Reported by: bill Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit Version: 1.6.0b1
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

Split the _Widget functionality needed by mobile/lightweight widgets into _WidgetBase class. _Widget will extend _WidgetBase and continue to function as before.

Update dojox.mobile to use _WidgetBase instead of _Widget.

This is partly being done because the dijitBaseExclude build pragma has stopped working due to the AMD refactor..

_WidgetBase:

  • dependencies: dijit/_base/manager only
  • essential code from current _Widget.js

_Widget:

  • extends _WidgetBase
  • dependencies: everything in dijit/_base
  • focus attribute and _onFocus()/_onBlur() methods (depends on dijit/_base/focus.js)
  • ondijitclick support
  • deferred connect stuff
  • deprecated methods

If necessary, in the future the focus and ondijitclick support can also be split off into mixins (and _Widget would extend those mixins).

Change History (11)

comment:1 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [23762]) Split the _Widget functionality needed by mobile/lightweight widgets into _WidgetBase class. _Widget extends _WidgetBase and continues to function as before.

Update dojox.mobile to use _WidgetBase instead of _Widget.

Fixes #12274 !strict.

comment:2 Changed 9 years ago by bill

(In [23824]) Remove dijit.base_sniff dependency except for (desktop browser) compatibility mode, refs #12274, fixes #12319 !strict.

comment:3 Changed 9 years ago by bill

(In [23829]) Forgot to remove dijit.base_sniff dependency for iPad, refs #12274, fixes #12319 !strict.

comment:4 Changed 9 years ago by bill

Keywords: 1.7-mobile added

comment:5 Changed 9 years ago by bill

(In [24039]) Remove unneeded closures, refs #12274 !strict.

comment:6 Changed 9 years ago by bill

(In [24344]) Avoid pulling in unnecessary dependencies by referencing _WidgetBase instead of _Widget, refs #12274 !strict

comment:7 Changed 9 years ago by bill

(In [24565]) Allow _KeyNavContainer and it's descendants to extend _WidgetBase rather than _Widget. Refs #12274 !strict.

comment:8 Changed 7 years ago by bill

In [31163]:

update _Contained API doc example to use _WidgetBase rather than _Widget, refs #12274 !strict

comment:9 Changed 7 years ago by bill

In [31164]:

fix comment to refer to _WidgetBase, refs #12274 !strict

comment:10 Changed 7 years ago by bill

In [31165]:

fix comment to refer to _WidgetBase, refs #12274 !strict

comment:11 Changed 7 years ago by bill

In [31180]:

Fix a few more API comments and test files to refer to _WidgetBase instead of _Widget. No code changes. Refs #12274.

Note: See TracTickets for help on using tickets.