Opened 9 years ago

Closed 8 years ago

#12271 closed defect (fixed)

[patch] [cla] StackedAreas and StackedLines don't work for an array of objects

Reported by: vvoovv Owned by: cjolif
Priority: high Milestone: 1.8
Component: Charting Version: 1.6.0b1
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

I attach the test case. Run it from dojox/charting/test/

Please add the usual check for type in every cycle through run.data in plot2d/Stacked.js: var v = typeof value == "number" ? value : value.y;

Attachments (2)

my_test_stacked.html (4.0 KB) - added by vvoovv 9 years ago.
test case
12271.patch (836 bytes) - added by vvoovv 9 years ago.
CCLA: CURS-IT

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by vvoovv

Attachment: my_test_stacked.html added

test case

comment:1 Changed 9 years ago by Eugene Lazutkin

Milestone: tbdfuture
Status: newassigned

Did you try it with the trunk?

comment:2 Changed 9 years ago by vvoovv

Yes, with the trunk.

The trunk/charting/plot2d/Stacked.js was changed last time 8 months ago. There are 2 cycles through run.data in it. The type of run.data[j] is not checked in either cycles

Changed 9 years ago by vvoovv

Attachment: 12271.patch added

CCLA: CURS-IT

comment:3 Changed 9 years ago by vvoovv

That was my first patch (CCLA from CURS-IT).

Just added check var v = typeof value == "number" ? value : value.y in each cycle through run.data in /charting/plot2d/Stacked.js.

Tested against my_test_stacked.html which should be opened from dojox/charting/tests

comment:4 Changed 9 years ago by bill

Summary: StackedAreas and StackedLines don't work for an array of objects[patch] [cla] StackedAreas and StackedLines don't work for an array of objects

comment:5 Changed 8 years ago by cjolif

Cc: cjolif added

comment:6 Changed 8 years ago by cjolif

Milestone: future1.8
Owner: changed from Eugene Lazutkin to cjolif
Status: assignednew

comment:7 Changed 8 years ago by cjolif

Resolution: fixed
Status: newclosed

In [27480]:

fixes #12271 + added the test case from vvovv (CURS-IT, CCLA)

Note: See TracTickets for help on using tickets.