Opened 8 years ago
Closed 8 years ago
#12271 closed defect (fixed)
[patch] [cla] StackedAreas and StackedLines don't work for an array of objects
| Reported by: | vvoovv | Owned by: | cjolif |
|---|---|---|---|
| Priority: | high | Milestone: | 1.8 |
| Component: | Charting | Version: | 1.6.0b1 |
| Keywords: | Cc: | cjolif | |
| Blocked By: | Blocking: |
Description
I attach the test case. Run it from dojox/charting/test/
Please add the usual check for type in every cycle through run.data in plot2d/Stacked.js: var v = typeof value == "number" ? value : value.y;
Attachments (2)
Change History (9)
Changed 8 years ago by
| Attachment: | my_test_stacked.html added |
|---|
comment:1 Changed 8 years ago by
| Milestone: | tbd → future |
|---|---|
| Status: | new → assigned |
Did you try it with the trunk?
comment:2 Changed 8 years ago by
Yes, with the trunk.
The trunk/charting/plot2d/Stacked.js was changed last time 8 months ago. There are 2 cycles through run.data in it. The type of run.data[j] is not checked in either cycles
comment:3 Changed 8 years ago by
That was my first patch (CCLA from CURS-IT).
Just added check var v = typeof value == "number" ? value : value.y in each cycle through run.data in /charting/plot2d/Stacked.js.
Tested against my_test_stacked.html which should be opened from dojox/charting/tests
comment:4 Changed 8 years ago by
| Summary: | StackedAreas and StackedLines don't work for an array of objects → [patch] [cla] StackedAreas and StackedLines don't work for an array of objects |
|---|
comment:5 Changed 8 years ago by
| Cc: | cjolif added |
|---|
comment:6 Changed 8 years ago by
| Milestone: | future → 1.8 |
|---|---|
| Owner: | changed from Eugene Lazutkin to cjolif |
| Status: | assigned → new |
Note: See
TracTickets for help on using
tickets.
test case