Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#12270 closed defect (fixed)

dojox.html.ellipsis fails loading on FF4

Reported by: talisto Owned by: Adam Peller
Priority: high Milestone: 1.5.2
Component: Dojox Version: 1.6.0b1
Keywords: Cc: Tom Trenka, Nathan Toone, Bryan Forbes
Blocked By: Blocking:

Description

dojox.html.ellipsis fails to load on the latest Firefox 4 beta, resulting in this error:

failed loading dojo/../dojox/html/ellipsis.js with error: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMHTMLDocument.createElementNS]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: http://sandbox.local/dojo.git/dojo/_base/_loader/bootstrap.js :: <TOP_LEVEL> :: line 495"  data: no]
http://sandbox.local/dojo.git/dojo/_base/_loader/loader.js
Line 146

I'm not sure if bug reports for beta versions of Firefox are desired, but Firefox 4 is almost at RC, so I thought it might be worth mentioning.

I've attached a simple test-case. I've tested this on Firefox 3 and it works fine. I've also tested that this error occurs on Firefox 4 with both Dojo 1.5 and Dojo 1.6b2.

This is the only component that I have experienced an error loading in Firefox 4 (so far).

Attachments (2)

loadtest.html (335 bytes) - added by talisto 9 years ago.
ellipsis.diff (3.0 KB) - added by Bryan Forbes 9 years ago.
Fix for 1.6

Download all attachments as: .zip

Change History (18)

Changed 9 years ago by talisto

Attachment: loadtest.html added

comment:1 Changed 9 years ago by bill

Component: GeneralDojox
Owner: changed from anonymous to Adam Peller

comment:2 Changed 9 years ago by Adam Peller

this code fails from the firebug console:

try{document.createElementNS('http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul','window');}catch(e){console.error(e)}

comment:3 Changed 9 years ago by Adam Peller

Milestone: tbd1.6
Priority: normalhigh

https://developer.mozilla.org/En/Firefox_4_for_developers#Remote_XUL_support_removed Means we'd better at least catch the exception going forward. Not sure if there's any other workable solution for ellipses on FF.

comment:4 Changed 9 years ago by Adam Peller

(In [23756]) Catch exception in FF 4.0 for using XUL. Refs #12270

comment:5 Changed 9 years ago by Adam Peller

Cc: Tom Trenka Nathan Toone added

This feature is presently broken for FF4+ so the code is useless going forward, unfortunately. How do we handle this?

comment:6 Changed 9 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [23758]) Add deprecation messages. Fixes #12270

comment:7 Changed 9 years ago by Adam Peller

(In [23759]) add warning for FF4. Refs #12270

comment:8 Changed 9 years ago by Adam Peller

(In [23760]) Correct version. Refs #12270

comment:9 Changed 9 years ago by Adam Peller

(In [23822]) ellipsis is deprecated. Refs #12270

comment:10 Changed 9 years ago by Adam Peller

Cc: Bryan Forbes added
Resolution: fixed
Status: closedreopened

I may have been too hasty. There's a non-XUL branch in there.

comment:11 Changed 9 years ago by Adam Peller

Milestone: 1.61.6.1

Changed 9 years ago by Bryan Forbes

Attachment: ellipsis.diff added

Fix for 1.6

comment:12 Changed 9 years ago by Bryan Forbes

I have attached a patch against the 1.6 branch that only wraps the XUL portion of the branch for Firefox in a try/catch. This allows the non-XUL function to run in FF4.

comment:13 Changed 9 years ago by Adam Peller

Thanks, Bryan! Applied to trunk in r24179

comment:14 Changed 9 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

(In [24182]) applying Bryan's patch to undeprecate ellipsis on 1.6 Fixes #12270

comment:15 Changed 9 years ago by bill

Summary: dojox.html.ellipsis fails loading on Firefox 4 beta (10)dojox.html.ellipsis fails loading on FF4

(just changing summary so searches for FF4 find this ticket in addition to the others)

comment:16 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: 1.6.11.5.2

Updating milestone to 1.5.2 to reflect inclusion in changeset [26956] for ticket #14199.

Note: See TracTickets for help on using tickets.