#12264 closed defect (fixed)
[patch][ccla] a GFX SVG shape that has been cleared from a surface can't be added back to the surface
| Reported by: | cjolif | Owned by: | Eugene Lazutkin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | DojoX GFX | Version: | 1.6.0b1 |
| Keywords: | 1.7-mobile | Cc: | |
| Blocked By: | Blocking: |
Description
When clearing a surface the parent reference of the removed shapes are not cleared. Thus when trying to add them back, the test that checks if the shape is already in is preventing the shape to be added back.
Additionally this can probably be the source of memory leak as a shape get a hold on the surface even after its removal. The fix consists in making sure to remove parent references when clearing the surface (dojox.gfx.shape.Container.clear).
Attached is a modified version of test_group2.html to show the issue (click to show the circle, click to clear the surface, click once more to show it back, it does not show up).
Attachments (2)
Change History (8)
Changed 9 years ago by
| Attachment: | test_group2.html added |
|---|
Changed 9 years ago by
| Attachment: | shape.path added |
|---|
comment:1 Changed 9 years ago by
| Milestone: | tbd → future |
|---|---|
| Status: | new → assigned |
Right. Probably we need to cascade destroy() as well.
comment:2 Changed 9 years ago by
| Keywords: | 1.7-mobile added |
|---|
comment:3 Changed 9 years ago by
| Milestone: | future → 1.7 |
|---|
comment:4 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
patch