Opened 8 years ago

Closed 6 years ago

#12263 closed enhancement (patchwelcome)

[patch] [cla] Include stack in DOH AssertError

Reported by: David Rees Owned by: David Rees
Priority: high Milestone: tbd
Component: TestFramework Version: 1.6.0b1
Keywords: DOH Cc: dave@…
Blocked By: Blocking:

Description

I have updated the AssertionError? creation in runner.js to include the stack if it’s available. With FireBug/Chrome? this means the test file’s link and line number are shown in the console. Patch is attached (works for 1.5 and 1.6).

This is best used with debugAtAllCosts, otherwise the filenames in the stack are just bootstrap.js.

Also see #12261 (adds debugAtAllCosts parameter to DOH runner.html) and #12260 (Fixes a bug in DOH 1.5 with regards to XD/debugAtAllCosts).

Attachments (1)

addStackToDOHAssertErrors.patch (840 bytes) - added by David Rees 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by David Rees

comment:1 Changed 8 years ago by Chris Mitchell

Owner: anonymous deleted

comment:2 Changed 7 years ago by bill

Component: GeneralTestFramework
Summary: Include stack in DOH AssertError[patch] [cla] Include stack in DOH AssertError

comment:3 Changed 7 years ago by bill

Hmm, not sure about this, at least on firefox the _AssertFailure already has a property called "trace" that has the stack.

comment:4 Changed 6 years ago by Kitson Kelly

Owner: set to David Rees
Status: newpending

If you are still interested in this, can we try a patch against current trunk?

I agree with bill that I think this has gone a significant way in current browser releases.

comment:5 Changed 6 years ago by David Rees

Status: pendingnew

It's a been a while since I have been touching this code, so leaving it pending is fine for me as well. If I do get back into the code I will try it with the latest...

comment:6 Changed 6 years ago by bill

Resolution: patchwelcome
Status: newclosed

That's not really how "pending" works, that's what "patchwelcome" is for.

Note: See TracTickets for help on using tickets.