Opened 10 years ago
Closed 7 years ago
#12263 closed enhancement (patchwelcome)
[patch] [cla] Include stack in DOH AssertError
| Reported by: | David Rees | Owned by: | David Rees |
|---|---|---|---|
| Priority: | high | Milestone: | tbd |
| Component: | TestFramework | Version: | 1.6.0b1 |
| Keywords: | DOH | Cc: | [email protected]… |
| Blocked By: | Blocking: |
Description
I have updated the AssertionError? creation in runner.js to include the stack if it’s available. With FireBug/Chrome? this means the test file’s link and line number are shown in the console. Patch is attached (works for 1.5 and 1.6).
This is best used with debugAtAllCosts, otherwise the filenames in the stack are just bootstrap.js.
Also see #12261 (adds debugAtAllCosts parameter to DOH runner.html) and #12260 (Fixes a bug in DOH 1.5 with regards to XD/debugAtAllCosts).
Attachments (1)
Change History (7)
Changed 10 years ago by
| Attachment: | addStackToDOHAssertErrors.patch added |
|---|
comment:1 Changed 9 years ago by
| Owner: | anonymous deleted |
|---|
comment:2 Changed 8 years ago by
| Component: | General → TestFramework |
|---|---|
| Summary: | Include stack in DOH AssertError → [patch] [cla] Include stack in DOH AssertError |
comment:3 Changed 8 years ago by
comment:4 Changed 7 years ago by
| Owner: | set to David Rees |
|---|---|
| Status: | new → pending |
If you are still interested in this, can we try a patch against current trunk?
I agree with bill that I think this has gone a significant way in current browser releases.
comment:5 Changed 7 years ago by
| Status: | pending → new |
|---|
It's a been a while since I have been touching this code, so leaving it pending is fine for me as well. If I do get back into the code I will try it with the latest...
comment:6 Changed 7 years ago by
| Resolution: | → patchwelcome |
|---|---|
| Status: | new → closed |
That's not really how "pending" works, that's what "patchwelcome" is for.
Hmm, not sure about this, at least on firefox the _AssertFailure already has a property called "trace" that has the stack.