Opened 9 years ago

Closed 8 years ago

#12261 closed enhancement (wontfix)

Add debugAtAllCosts parameter to DOH runner.html

Reported by: David Rees Owned by: David Rees
Priority: high Milestone: tbd
Component: TestFramework Version: 1.5
Keywords: DOH debugAtAllCosts Cc: dave@…
Blocked By: Blocking:

Description

As described in this thread, I have modified runner.html to allow adding debugAtAllCosts=true to the URL parameters to turn debugAtAllCosts on. I find it quite useful since it gives me errors with the right file/line and also supports debugging.

I've attached a patch file for 1.5.0 and for 1.6b2. The code change is the same for both versions, but surrounding code is different in the two versions so actual .patch files are slightly different.

Note that DOH 1.5.0 has a bug with regards to debugAtAllCosts. The ticket and patch for that are at #12260.

Attachments (3)

Change History (11)

comment:1 Changed 9 years ago by David Rees

Also see #12262 (test modules tests.i18n, tests.date.locale, test.number break when using XD/debugAtAllCosts).

comment:2 Changed 9 years ago by David Rees

Also see #12263 (Include stack in DOH AssertError?)

comment:3 Changed 9 years ago by David Rees

As I look at this more with 1.6b2, I wanted to mention that it doesn't do anything with 1.6b2 because the loader does not support async loading yet (http://docs.dojocampus.org/releasenotes/1.6#id10). I think the patch is still valid for when it does though. That said, the djConfig line will also need to be updated to the new data-dojo-config as well.

Once 1.6 supports async loading I will probably come back and look at this.

In the meantime it is working great in 1.5.0 when combined with #12260 and #12263.

comment:4 Changed 8 years ago by Chris Mitchell

Owner: anonymous deleted

comment:5 Changed 8 years ago by ben hockey

Owner: set to David Rees
Status: newpending

reesd, is there any need to keep this ticket open? it seems from your comments that 1,6 and presumably 1.7 shouldn't have this problem.

comment:6 Changed 8 years ago by ben hockey

Resolution: fixed
Status: pendingclosed

comment:7 Changed 8 years ago by bill

Component: GeneralTestFramework
Resolution: fixed
Status: closedreopened

Probably should mark this as wontfix instead, since the debugAtAllCosts parameter is no longer needed after the conversion of everything to AMD format. So changing the status to wontfix.

comment:8 Changed 8 years ago by bill

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.