#12253 closed defect (fixed)
[patch][cla] Dijit themes: replace instances of '0px' and '0%' with '0'
| Reported by: | Kenneth G. Franqueiro | Owned by: | Kenneth G. Franqueiro |
|---|---|---|---|
| Priority: | high | Milestone: | 1.6 |
| Component: | Dijit - LnF | Version: | 1.6.0b1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
The specification of 0 values across claro styles is inconsistent - most often it is specified as 0px, sometimes 0, and a few times even 0%. All of these are equivalent, so just 0 can be used to save bytes.
This should be easily scriptable, with something like the following:
find -name '*.less' | xargs egrep -l '\b0px' | xargs sed -i -e 's/\b0px/0/g'
(Assuming replacement within the .less files, then regeneration of the .css files using compile.js.)
This could potentially be applied to the css files on other themes as well - there seem to be a number of 0px instances particularly, though claro seems to have far more occurrences.
Attachments (1)
Change History (5)
Changed 10 years ago by
| Attachment: | 12253.diff added |
|---|
comment:1 Changed 10 years ago by
| Summary: | Dijit themes: replace instances of '0px' and '0%' with '0' → [patch][cla] Dijit themes: replace instances of '0px' and '0%' with '0' |
|---|
comment:2 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 10 years ago by
| Milestone: | tbd → 1.6 |
|---|
Note: See
TracTickets for help on using
tickets.
Diff resulting from running sed to replace 0px and 0% with 0 across dijit/themes