Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12253 closed defect (fixed)

[patch][cla] Dijit themes: replace instances of '0px' and '0%' with '0'

Reported by: Kenneth G. Franqueiro Owned by: Kenneth G. Franqueiro
Priority: high Milestone: 1.6
Component: Dijit - LnF Version: 1.6.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

The specification of 0 values across claro styles is inconsistent - most often it is specified as 0px, sometimes 0, and a few times even 0%. All of these are equivalent, so just 0 can be used to save bytes.

This should be easily scriptable, with something like the following:

find -name '*.less' | xargs egrep -l '\b0px' | xargs sed -i -e 's/\b0px/0/g'

(Assuming replacement within the .less files, then regeneration of the .css files using compile.js.)

This could potentially be applied to the css files on other themes as well - there seem to be a number of 0px instances particularly, though claro seems to have far more occurrences.

Attachments (1)

12253.diff (141.8 KB) - added by Kenneth G. Franqueiro 8 years ago.
Diff resulting from running sed to replace 0px and 0% with 0 across dijit/themes

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Kenneth G. Franqueiro

Attachment: 12253.diff added

Diff resulting from running sed to replace 0px and 0% with 0 across dijit/themes

comment:1 Changed 8 years ago by Kenneth G. Franqueiro

Summary: Dijit themes: replace instances of '0px' and '0%' with '0'[patch][cla] Dijit themes: replace instances of '0px' and '0%' with '0'

comment:2 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: newclosed

(In [23730]) Removing unnecessary unit specifications from 0 values in theme CSS. Fixes #12253

comment:3 Changed 8 years ago by Kenneth G. Franqueiro

(In [23731]) Oops, forgot about 0em. Refs #12253

comment:4 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: tbd1.6
Note: See TracTickets for help on using tickets.