[regression] RTL: missing right border on ComboBox arrow buttons in 1.6 betas

[Kenneth G. Franqueiro]

If you look at e.g. ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/_autoComplete.html?testWidget=dijit.form.FilteringSelect&dir=rtl you will notice that the right side of the drop-down arrow button is missing its border. This looked fine in 1.5, seems to be missing in all browsers on 1.6 beta 1 and 2.

It seems as if the culprit is the styles added to dijit_rtl.css in [22885]; not sure what the reason behind that addition was.

[bill]

That is mysterious code added in [22885]:

.dijit_a11y .dijitToolbar .dijitTextBoxRtl .dijitValidationContainer,
.dijitTextBoxRtl .dijitSpinnerButtonContainer,
.dijitComboBoxRtl .dijitArrowButtonContainer  {
	border-right-width: 0 !important;
	border-right-style: none !important;
}

Jared, can we just remove that whole thing? It contradicts the rule above it.

[Jared Jurkiewicz]

That was added by Katy to fix issues witht the dropdown border/enablement when used in dijit toolbars, such as in the dropdowns used in font choice by Editor. Feel free to remove it, but verify that it doesn't break the dropdowns in editor.

[bill]

(In [23741]) Fixes to the border between ComboBox's input area and arrow icon:

• border wasn't showing up in RTL mode (it should)
• border was showing up for a ComboBox in a Toolbar (it shouldn't, ComboBoxes in Toolbars have special styling)

Also removed some unneeded a11y rules, though there are still unnecessary rules left, setting border color and width.

Fixes #12252.