#12244 closed defect (fixed)
[patch][cla] Claro: make border-radius and box-shadow styles consistent across vendors/standards
| Reported by: | Kenneth G. Franqueiro | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5.2 |
| Component: | Dijit - LnF | Version: | 1.6.0b1 |
| Keywords: | IE9 claro | Cc: | |
| Blocked By: | Blocking: |
Description (last modified by )
This bug originally started with the following observation in IE9 RC:
If you look at e.g. dijit/tests/form/test_Button.html and look at the ComboButtons, the "inner" corners (those neighboring both the main button and drop-down button) are rounded, which shouldn't be the case (check any other browser for reference).
This seems to be due to missing overriding border-radius styles on a couple of selectors, while the vendor-specific versions are present.
After discussion with Bill, it's been determined that this is a general problem across claro CSS, so this effort has been expanded to try to resolve this wherever it occurs.
Attachments (2)
Change History (9)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | [patch][cla] IE9: Claro: "inner" corners of ComboButtons are rounded but shouldn't be → [patch][cla] Claro: make border-radius and box-shadow styles consistent across vendors/standards |
Changed 8 years ago by
comment:3 Changed 8 years ago by
Just FYI - the only "regression" I've seen so far (vs. beta 2) is that in IE9 RC, in RTL mode only, the background of anything with rounded borders gets nullified. I'm figuring this has to be a bug on their end, and I certainly can't consider leaving out the standard property just for its sake.
Changed 8 years ago by
| Attachment: | 12244.patch added |
|---|
Patch that should make all border-radius and box-shadow styles consistent.
comment:4 Changed 8 years ago by
Looks good to me, definitely cleaner then before. The only weird thing is, I don't know why ColorPalette is specifying a border-radius at all, but I realize it was that way from before.
comment:5 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 8 years ago by
| Milestone: | tbd → 1.6 |
|---|
comment:7 Changed 8 years ago by
| Milestone: | 1.6 → 1.5.2 |
|---|
Thanks, please make sure that all the rules with -moz-border-radius and -moz-box-shadow have corresponding border-radius and box-shadow properties, and test they are working on IE in dir=ltr and dir=rtl mode.
Also, the -webkit-border-radius rules are no longer necessary (plain border-radius is working on safari and chrome), so they should be removed. The -webkit-box-shadow rules still seem to be necessary.