dijit.form.DropDownButton's menu items show in the top left corner of browser when display is set none

[Jean-Rubin Leonard]

When the display attribute of the dijit.form.DropDownButton is initially set to none, and then we set it to display inline to make it show, its menuitems show on the top-left corner of the browser instead of right under the drop down button.

[bill]

Inside of place.js it does:

// get coordinates of aroundNode
aroundNode = dojo.byId(aroundNode);
var oldDisplay = aroundNode.style.display;
aroundNode.style.display="";
// #3172: use the slightly tighter border box instead of marginBox
var aroundNodePos = dojo.position(aroundNode, true);
aroundNode.style.display=oldDisplay;

The aroundNode in this case is your DropDownButton, and setting display to "" causes the button to be hidden due to this CSS in your test file:

.MainUnitButton{display:none;}

So the obvious way to make this work is to not have that CSS.

I can trace the code above back to [4644], apparently it was trying to make the aroundNode visible when it was hidden (although it's having the opposite effect for you), but I'm not sure when the aroundNode would ever be hidden, so I can probably remove that code.

[bill]

(In [23717]) Remove code from [4644] trying to make sure aroundNode is visible. The aroundNode is presumably already visible, and the code can actually backfire in a corner case, causing the aroundNode to be hidden (see #12242 test case). Fixes #12242 !strict.