Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12239 closed defect (fixed)

OAuth module, parameter=0 results to parameter= in baseString

Reported by: dimm Owned by: Tom Trenka
Priority: high Milestone: 1.7
Component: Dojox Version: 1.5
Keywords: OAuth Cc:
Blocked By: Blocking:

Description

If the GET string contains "parameter=0", the signature in OAuth.js is calculated for string with "parameter=" because of the wrong check "if(s)"

The fix is to replace line 23 of dojox.io.OAuth.js:

if(s+"" == ""){ return ""; }

and line 199:

return encode(item[0]) + "=" + encode((item[1]+""!="")?item[1]:"");

Tested in Chrome and Firefox, OS X

Change History (3)

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from Adam Peller to Tom Trenka

comment:2 Changed 9 years ago by Tom Trenka

Resolution: fixed
Status: newclosed

Thanks for the ticket, should be fixed as of today. Took a slightly different approach but should work the same.

comment:3 Changed 9 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.