Opened 8 years ago

Closed 8 years ago

#12236 closed enhancement (fixed)

[patch][ccla] avoid Spider plot2d to require dijit

Reported by: cjolif Owned by: Eugene Lazutkin
Priority: high Milestone: 1.6
Component: Charting Version: 1.6.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

In the exact same spirit as http://bugs.dojotoolkit.org/ticket/12208, the Spider.js of plot2d can test for tooltip availability and show them only if available instead of forcing the full dijit stack to be loaded (especially useful on mobile).

This patch is also removing a dojo.require("dojox.charting.widget.Legend") statement in the code that is useless and also create a (non useful) dijit dependency.

Attachments (2)

Spider.patch (1.5 KB) - added by cjolif 8 years ago.
Spider patch to remove dijit dependency
test_spider2d.patch (549 bytes) - added by cjolif 8 years ago.
test case patch to require Tooltip for them to display

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by cjolif

Attachment: Spider.patch added

Spider patch to remove dijit dependency

Changed 8 years ago by cjolif

Attachment: test_spider2d.patch added

test case patch to require Tooltip for them to display

comment:1 Changed 8 years ago by Eugene Lazutkin

Milestone: tbd1.6

comment:2 Changed 8 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [23833]) charting: made dependency on dijit.Tooltip optional in Spider chart, thx cjolif!, !strict, fixes #12236.

Note: See TracTickets for help on using tickets.