Opened 9 years ago

Closed 9 years ago

#12208 closed enhancement (fixed)

[patch][ccla] Avoid Default chart axis to require dijit

Reported by: cjolif Owned by: Eugene Lazutkin
Priority: high Milestone: 1.6
Component: Charting Version: 1.6.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

The label truncation & tooltip feature has introduced a dependency on dijit.Tooltip and thus dijit in general in Chart Default axis. This is a lot of download for charts that do not require this (especially important on mobile).

This patch is removing the dijit.Tooltip require & dynamically testing for its presence before display before displaying a tooltip.

It also updates the test accordingly.

This share the same purpose as: ​http://trac.dojotoolkit.org/ticket/12149 in order to get lighter charts.

Attachments (2)

test_label_shortening.patch​ (533 bytes) - added by cjolif 9 years ago.
test patch
Default.patch​ (1.3 KB) - added by cjolif 9 years ago.
patch Default.js axis

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by cjolif

Attachment: test_label_shortening.patch​ added

test patch

Changed 9 years ago by cjolif

Attachment: Default.patch​ added

patch Default.js axis

comment:1 Changed 9 years ago by Eugene Lazutkin

Status: new → assigned

comment:2 Changed 9 years ago by Eugene Lazutkin

Resolution: → fixed
Status: assigned → closed

(In [23686]) charting: small rearrangements to reduce the need for Tooltip widget, when not used, thx Christophe Jolif (IBM, CCLA), !strict, fixes #12208.

Note: See TracTickets for help on using tickets.