Opened 9 years ago

Closed 9 years ago

#12190 closed defect (fixed)

Doc parser could understand AMD format

Reported by: dante Owned by: dante
Priority: high Milestone: 1.6
Component: Doc parser Version: 1.6.0b1
Keywords: Cc: Tom Trenka, Neil Roberts, Dustin Machi
Blocked By: Blocking:

Description

The doc parser uses dojo.provide/require to build up deps and so forth, so I ported _most_ of the amd-unwrapping code in buildUtil to PHP and made the doc parser aware of the format.

We currently have to run a build to get the unwrapping done to do the API doc generation. Also the 'crude preview' tool does not understand AMD format as it is just using the parser against the raw source.

Faking the unwrapping when detected allows the browser to show key stuff, but we should probably still be running a build for the API docs anyway.

Attachments (1)

amd-docparser.patch (2.9 KB) - added by dante 9 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by dante

Milestone: tbd1.6

so the current patch allows the entire generate.php script to run against svn trunk. handles a variety of formats(? really just AMD-ID and define(name, deps).

also updates _browse to use tabs and refresh and other things.

also fixes the styleguide stuff from the unwrap function in fileutil.js

Changed 9 years ago by dante

Attachment: amd-docparser.patch added

comment:2 Changed 9 years ago by Tom Trenka

(In [23648]) Committing Pete's AMD patch to dojo2.inc, !strict refs #12190

comment:3 Changed 9 years ago by Tom Trenka

Resolution: fixed
Status: newclosed

Resolving this ticket because Pete's patch works ;)

Note: See TracTickets for help on using tickets.