Opened 10 years ago

Closed 10 years ago

#12189 closed defect (fixed)

Minor dojo.store issues

Reported by: vladar Owned by: Kris Zyp
Priority: high Milestone: 1.6
Component: Data Version: 1.6.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

While reviewing dojo-1.6.0b1 I've noticed several minor issues:

  1. "id" variable is global in Memory store, method "put" (line 47)
  2. there is a trailing comma in the object definition, which messes up IE in JsonRest? store, method "put" (line 58)

Also, looks like there is no dedicated component in Trac yet for dojo store API, so assigned to dojo.data

Attachments (1)

store-lint-doc-fixes.patch​ (19.1 KB) - added by Kenneth G. Franqueiro 10 years ago.
Updated to also remove EOL whitespace as pointed out by dante. Also, note: will have to view raw, trac doesn't seem to like big patches.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 10 years ago by bill

Owner: changed from Jared Jurkiewicz to Kris Zyp

Changed 10 years ago by Kenneth G. Franqueiro

Attachment: store-lint-doc-fixes.patch​ added

Updated to also remove EOL whitespace as pointed out by dante. Also, note: will have to view raw, trac doesn't seem to like big patches.

comment:2 Changed 10 years ago by Kenneth G. Franqueiro

Resolution: → fixed
Status: new → closed

(In [23613]) dojo.store cleanup: removing stray comma, fixing leaked global, adding missing semicolons, fixing indentation of inline docs, and removing trailing whitespace. Fixes #12189 !strict

Note: See TracTickets for help on using tickets.