Opened 9 years ago

Closed 9 years ago

#12181 closed defect (fixed)

Build interning breaks on filenames with hypens.

Reported by: dante Owned by: dante
Priority: high Milestone: 1.6
Component: BuildSystem Version: 1.6.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

eg

var x = dojo.cache("myns", "file-name.html");

The regexp matching the filename bit only allows /'s and \w+'s:

([\\w\\.\\/]*)

adding a - to that block fixes:

([\\w\\.\\/-]*)

in buildUtil.js - buildUtil.interningDojoUriRegExpString

too late for 1.6?

Attachments (1)

buildintern.patch (1.4 KB) - added by dante 9 years ago.

Download all attachments as: .zip

Change History (2)

Changed 9 years ago by dante

Attachment: buildintern.patch added

comment:1 Changed 9 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: newclosed

(In [23584]) Committing dante's buildscript patch for hyphenated filename interning explosions, after re-testing locally. Fixes #12181 and ditches a superfluous print.

Note: See TracTickets for help on using tickets.