Opened 10 years ago
Closed 10 years ago
#12177 closed defect (fixed)
[patch][ccla] wipeIn/Out stop not cleaning up style changes
Reported by: | Douglas Hays | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | fx | Version: | 1.6.0b1 |
Keywords: | Cc: | dante, Eugene Lazutkin | |
Blocked By: | Blocking: |
Description
fx.wipeIn and wipeOut both set style.overflow=hidden when they start, and then resets this onEnd. But if stop() is called, the style changes are made permanent. The same style cleanup should also occur onStop. This was found by a customer using dijit.Tree. When a node was double-clicked, it expands and collapses more quickly than the animation and the overflow=hidden remains which truncates the node label.
Attachments (1)
Change History (7)
Changed 10 years ago by
Attachment: | 12177.patch added |
---|
comment:1 Changed 10 years ago by
Cc: | dante Eugene Lazutkin added |
---|---|
Summary: | wipeIn/Out stop not cleaning up style changes → [patch][ccla] wipeIn/Out stop not cleaning up style changes |
I'd like to get the attached patch reviewed and committed for 1.6 if possible. I included an automated test for both wipeIn and wipeOut.
comment:2 Changed 10 years ago by
Owner: | changed from Bryan Forbes to bryanforbes |
---|
comment:3 Changed 10 years ago by
Owner: | changed from bryanforbes to Bryan Forbes |
---|
comment:4 Changed 10 years ago by
Milestone: | 1.6 → 1.7 |
---|
Any challenges to me committing this patch into trunk (1.7)?
comment:5 Changed 10 years ago by
Owner: | changed from Bryan Forbes to Douglas Hays |
---|---|
Status: | new → assigned |
comment:6 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
patch for review