Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12128 closed defect (fixed)

HorizontalSlider has extra dependency

Reported by: Rawld Gill Owned by: Douglas Hays
Priority: high Milestone: 1.6
Component: Dijit - Form Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

dijit/form/horizontalSlider includes the dependency dojo/_base/fx. This seems unnecessary (it is the only resource in the dijit tree that includes a dojo/_base dependency) Can we remove it? Or is there some odd use case in play?

Change History (7)

comment:1 Changed 9 years ago by Rawld Gill

Owner: set to bill

comment:2 Changed 9 years ago by bill

Owner: changed from bill to Douglas Hays

I guess so, it's from [11425]. I know that certain groups want dijit to run really lightly, not including all of dojo/_base (in particular dojo.query()), but I don't think as a rule that we do specific dojo.require() calls for each file in dojo/_base.

comment:3 Changed 9 years ago by Douglas Hays

I don't understand what is being proposed. Is it to change dojo/_base/fx to dojo/fx (which will in turn bring in more than needed) or is it to remove animation from the Slider widget?

comment:4 Changed 9 years ago by bill

I think Rawld was just saying to remove "dojo/_base/fx" from the list of dependencies (i.e. the array passed to the define() function). The _base/fx stuff is already loaded via the first entry in the dependency list: "dojo".

comment:5 Changed 9 years ago by Douglas Hays

Milestone: tbd1.6
Status: newassigned

comment:6 Changed 9 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [23467]) Fixes #12128. Remove redundant dojo/_base/fx dependency from HorizontalSlider?. dojo/_base optionally (based upon isBrowser) requires _base/browser which in turn requires dojo/_base/fx.

comment:7 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.