Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1212 closed defect (fixed)

[patch][cla] Logger was only logging the first argument

Reported by: attila.lendvai@… Owned by: dylan
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

This is a new logType method that fixes the problem.

logType: function(type, args){

if (!dojo.lang.isArray(args)){

args = this.argsToArr(args);

} return this.log.apply(this, [dojo.logging.log.getLevel(type),

args.join()]);

}

Attachments (1)

logger-was-only-logging-first-arg.patch (916 bytes) - added by attila.lendvai@… 13 years ago.
the fix with svn diff

Download all attachments as: .zip

Change History (9)

comment:1 Changed 13 years ago by dylan

Milestone: 0.4
Owner: changed from anonymous to dylan
Status: newassigned

Changed 13 years ago by attila.lendvai@…

the fix with svn diff

comment:2 Changed 13 years ago by dylan

Attila, have you filed a Contributor License Agreement (CLA, http://dojotoolkit.org/foundation/ )? I don't have one on file for you....

comment:3 Changed 13 years ago by dylan

Summary: Logger was only logging the first argument[patch][need cla] Logger was only logging the first argument

comment:4 Changed 13 years ago by attila.lendvai@…

not yet, i need to get to a printer. i'll try to send a picture of it signed later today...

  • attila

comment:5 Changed 13 years ago by attila.lendvai@…

fyi, i've sent my signed cla in email to dylan@… and carrie@…

  • attila

comment:6 Changed 13 years ago by dylan

Summary: [patch][need cla] Logger was only logging the first argument[patch][cla] Logger was only logging the first argument

comment:7 Changed 13 years ago by dylan

Resolution: fixed
Status: assignedclosed

(In [5768]) logger was onlu logging first arg, fixes #1212, thanks for the patch

comment:8 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.