Opened 10 years ago
Closed 10 years ago
#12109 closed defect (fixed)
[regression] dijit.hasDefaultTabStop failure with editor iframe on WebKit
Reported by: | Douglas Hays | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Run dijit/tests/_base/tabindex.html on Chrome or Safari. There's 1 failure in the isTabNavigable function with hint editor_iframe. The problem is that a new child DIV with contentEditable=true has been added to Editor for the Webkit case. It'll be hard to always keep this function in sync with Editor. I think a feature-detection algorithm might be better. Please review the attached patch for a first draft at this.
Attachments (1)
Change History (3)
Changed 10 years ago by
Attachment: | 12109.patch added |
---|
comment:1 Changed 10 years ago by
Status: | new → assigned |
---|
comment:2 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
That code is originally from #9766.
Your patch looks good except that we don't want dijit._base to depend on dojo.query(), since it's such a big chunk of code. I'll check in a modified version, slightly less robust but not using dojo.query().