Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12100 closed defect (fixed)

unresolved event references should show error in console

Reported by: Adam Peller Owned by: bill
Priority: high Milestone: 1.6
Component: Parser Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

presently, if you have data-dojo-props="onClick:undefinedFunction" you'll get a console.warning. This is the same level we use to report deprecation. It should probably be console.error.

Change History (8)

comment:1 Changed 8 years ago by Adam Peller

Description: modified (diff)

comment:2 Changed 8 years ago by Adam Peller

I suppose we could also throw, but that might be a bit harsh

comment:3 Changed 8 years ago by bill

Milestone: tbd1.6

I was actually thinking of throwing too, especially since this is a new feature so people can't complain about a change in behavior.

comment:4 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

(In [23455]) Throw error if data-dojo-props doesn't eval. This is consistent with other errors in the parser, such as data-dojo-type not resolving to a class. Fixes #12100 !strict.

comment:5 Changed 8 years ago by bill

(In [23456]) Throw error if data-dojo-props doesn't eval. This is consistent with other errors in the parser, such as data-dojo-type not resolving to a class. Fixes #12100 !strict.

comment:6 Changed 8 years ago by bill

(In [23460]) For DOH test files, call parser from DOH so that parse errors appear as test failures. Also making tests AMD compatible by moving dojo.declare() etc. code inside of the dojo.addOnLoad(). Refs #12100.

comment:7 Changed 8 years ago by bill

(In [23583]) Call parser from DOH so that parse errors appear as test failures. Also fixing some spacing errors. Refs #12100.

comment:8 Changed 8 years ago by bill

(In [23938]) Call parser as part of DOH, so errors are reported. Also fixing missing dojo.require("dojo.parser"). Refs #12100.

Note: See TracTickets for help on using tickets.