Opened 9 years ago

Closed 4 years ago

Last modified 4 years ago

#12090 closed enhancement (fixed)

[patch] dojox.av.FLAudio: Delegate any Flash embedding errors to onError()

Reported by: Thomas Bachem Owned by: dylan
Priority: high Milestone: 1.7.9
Component: Dojox Version: 1.5
Keywords: Cc: Tom Trenka
Blocked By: Blocking:

Description

The FLAudio component does have its own "onError" handler, but Flash embedding errors returned by dojox.embed.Flash are not delegated to it. They instead get directly logged to the console right now.

I think that should be changed so one can react to these errors too.

So line 129 of dojox/av/FLAudio.js shoukd be changed from:

this._flashObject.onError = function(err){
    console.warn("Flash Error:", err);
};

to:

this._flashObject.onError = dojo.hitch(this, this.onError);

Change History (9)

comment:1 Changed 9 years ago by Adam Peller

Cc: Tom Trenka added
Owner: changed from Adam Peller to Mike Wilcox

comment:2 Changed 9 years ago by Mike Wilcox

Milestone: tbdfuture

comment:3 Changed 4 years ago by dylan

Owner: changed from Mike Wilcox to dylan
Status: newassigned

comment:4 Changed 4 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In b721c4799b1706d5bd5433fc333fc1c8dbd2d402/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 4 years ago by dylans <dylan@…>

In a538fd94d17c99bb0d8b162bfe1679ac2a957f92/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 4 years ago by dylans <dylan@…>

In d32dc202fe1b00ee8605951606295aea3a04114c/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 4 years ago by dylans <dylan@…>

In b4db4329808f34c7d7a5ec592691c0425308fb13/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 4 years ago by dylans <dylan@…>

In a66a9ece956013439cd84c9cdebfe3998aaf40a0/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 4 years ago by dylan

Milestone: future1.7.9
Note: See TracTickets for help on using tickets.