Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#12082 closed enhancement (fixed)

EnhancedGrid - nested sorting refactor

Reported by: evan Owned by: bryanforbes
Priority: high Milestone: 1.6
Component: DojoX Grid Version: 1.5
Keywords: edg nested sorting Cc: [email protected]…; [email protected]…; [email protected]
Blocked By: Blocking:


Nested sorting is refactored for 1.6 with:

  1. Smaller code size
  1. Simpler UI strucutre
  1. Performance improvements for scenario of large set of columns
  1. Support for default nested sorting order(#11286)
  1. Disabling nested sorting for a columns(#11447)
  1. JS API for dynamically setting nested sorting order(by reusing setSortIndex() API from base DataGrid?)

[Remained works]

  1. Fix focus & keyboard issues
  1. Fix RTL & A11y
  1. Claro styling issues
  1. Test & fix potential compatibility issues with various base Grid api & usages

Attachments (1)

nestedsorting.patch (76.1 KB) - added by evan 11 years ago.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by evan

Attachment: nestedsorting.patch added

comment:1 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [23358]) Fixes #12082. Proxy commit for evan (IBM, CCLA). EnhancedGrid? sorting fixes.

comment:2 Changed 11 years ago by Evan

(In [23626]) Refs #12082 1. fix comments, typo, strict coding styles 2. use '_currMainSort' to track the current main sorting order

comment:3 Changed 11 years ago by evan

(In [23634]) Refs #12082, fix a11y issue(high contrast mode) by adding sorting status tips(only visible in high contrast mode)

comment:4 Changed 11 years ago by evan

(In [23636]) Refs #12082, css styling tweaks for focusing(reuse the same style set with xxxcellOver), also add missed css support for tundra

comment:5 Changed 11 years ago by evan

(In [23637]) Refs #12082, revised sprite icons used with [23636]

comment:6 Changed 11 years ago by evan

(In [23705]) Refs #12082, always disconnect events to avoid potential leaks, tweak css for ie6, !strict

comment:7 Changed 11 years ago by evan

(In [23772]) Adjust "if" sequence since isNaN([]) returns false for empty [], refs #12082, !strict

comment:8 Changed 11 years ago by evan

(In [23796]) Related init work for sorting buttons if column headers are not recreated after Grid.render(), nls title tip, refs #12082, !strict

comment:9 Changed 11 years ago by evan

(In [23805]) tweak ie6 style fixes, refs #12082

comment:10 Changed 11 years ago by evan

(In [23820]) Remove focus style when grid is blured; css fix; refs #12082, !strict

comment:11 Changed 11 years ago by evan

(In [23825]) adjust css position when sorting hovered, refs #12082

comment:12 Changed 10 years ago by evan

(In [25830]) Refs #12082 !strict safely make grid.getSortIndex() do nothing when NestedSorting? is on

Note: See TracTickets for help on using tickets.