Opened 8 years ago

Closed 7 years ago

#12023 closed defect (fixed)

Multiple LightboxDialog instances on one page share groups and don't hide properly

Reported by: michitux Owned by: dante
Priority: high Milestone: 1.6
Component: Dojox Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

When there are multiple LightboxDialog? instances on a page (e.g. because different settings for these lightboxes are needed) they share the groups because the _groups attribute is actually a class attribute.

When multiple dijit.Dialog instances (e.g. multiple LightboxDialog? instances, though that doesn't really make sense) are opened, hide() in dijit.Dialog only actually hides the dialog when it is the dialog that is displayed on top. As the LightboxDialog? connects the underlay to the onCancel event, the underlay does fire onCancel for LightboxDialog? instances that are below other dijit.Dialog instances. The LightboxDialog? then hides everything, but the actual dialog isn't closed. I think the LightboxDialog? should rather react on the onHide() event that is fired by dijit.Dialog when it actually closes the dialog.

Change History (3)

comment:1 Changed 8 years ago by Adam Peller

Owner: changed from Adam Peller to dante

comment:2 Changed 8 years ago by dante

Milestone: tbd1.7
Status: newassigned

makes sense. updating the test page to include a breaking procedure would be helpful. no time for 1.6 left really.

comment:3 Changed 7 years ago by bill

Milestone: 1.81.6
Resolution: fixed
Status: assignedclosed

Looks like this was already fixed by [22511].

Note: See TracTickets for help on using tickets.