Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#12014 closed defect (fixed)

Posible bug in dojox.storage.manager

Reported by: danielon Owned by: Jens Arps
Priority: high Milestone: 1.6
Component: Dojox Version: 1.5
Keywords: Cc: herrerodani@…, Jens Arps
Blocked By: Blocking:

Description

Hello, this my first time issuing a ticket! I have detected that in dojox.storage.manager in line 151, function removeOnLoad the following line may be wrong:

this._onLoadListeners = this._onLoadListeners.splice(i, 1);

splice returns the removed elements, so this._onLoadListeners gets filled with the function you are trying to delete! I think the line should be changed to:

this._onLoadListeners.splice(i, 1);

Thank you very much!

Change History (7)

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from Adam Peller to Shane O'Sullivan

comment:2 Changed 9 years ago by Adam Peller

Cc: Jens Arps added
severity: blockermajor

comment:3 Changed 9 years ago by Shane O'Sullivan

Owner: changed from Shane O'Sullivan to Jens Arps

Jens, can you take a look at this?

comment:4 Changed 8 years ago by Jens Arps

Status: newassigned

Yes, sure, will do. Uh, and sorry for the late reply, I didn't get the notification mails.

comment:5 Changed 8 years ago by Jens Arps

Valid point, this is a bug. Thanks to danielon for finding and reporting!

comment:6 Changed 8 years ago by Jens Arps

Resolution: fixed
Status: assignedclosed

Fixed by [23569].

comment:7 Changed 8 years ago by bill

Milestone: tbd1.6

bulk update: bugs fixed in past few months, presumably milestone is 1.6

Note: See TracTickets for help on using tickets.