#12001 closed defect (fixed)
[patch] [ccla] ScrollableView does not work with dojo-1.4
Reported by: | ykami | Owned by: | Shane O'Sullivan |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | DojoX Mobile | Version: | 1.5 |
Keywords: | Cc: | Jared Jurkiewicz | |
Blocked By: | Blocking: |
Description
It works fine with dojo-1.3 and dojo-1.5, but not with dojo-1.4. Mixed-in methods seem to be missing.
Attachments (1)
Change History (8)
Changed 10 years ago by
Attachment: | 12001.patch added |
---|
comment:1 Changed 10 years ago by
Cc: | Jared Jurkiewicz added |
---|
While this patch is simple and doesn't even directly affect 1.6 functionality, I think this patch needs to be reviewed/committed by Jared and/or Shane since it is adding special code to work with dojo 1.4. Apparently the dojox/mobile code is being used by some customers who either cannot or will not move up to 1.6 in the near future but who require mobile capabilities. Besides adding a small amount of code bloat (and why not fix the underlying dojo 1.4 problem?), supporting customers on older dojo versions will lock dojox/mobile into non-AMD style module definitions and non-HTML5 compliant test files.
comment:2 Changed 10 years ago by
Summary: | ScrollableView does not work with dojo-1.4 → [patch] [ccla] ScrollableView does not work with dojo-1.4 |
---|
comment:3 Changed 10 years ago by
It would be better to not hard code in the exact version to match. How about checking just that the minor version is less than 1.5?
Doug, how about we leave this as it is for 1.6, which is the last version the 1.4 guys can use, and fix it in a point release to use the new system?
comment:4 Changed 10 years ago by
I agree with Shane. We leave it in non-AMD format for 1.6, then switch it over post 1.6 to be AMD and get rid of the check.
comment:5 Changed 10 years ago by
It also sounds like the issue he's working around was 1.4 specific, so the check it's doing for exactly that is probably fine.
comment:6 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:7 Changed 10 years ago by
Milestone: | tbd → 1.6 |
---|
Patch from Yoshiroh Kamiyama (IBM, CCLA) to avoid an inheritance problem on dojo 1.4 (#10709 and #10788)