Opened 9 years ago

Closed 3 years ago

#11985 closed defect (patchwelcome)

Thumbnailpicker inside dojo dialog does not work correctly

Reported by: YaPeL Owned by: dante
Priority: high Milestone: 1.13
Component: Dojox Version: 1.5
Keywords: Thumbnailpicker Dialog Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

As seen here: http://dojo-toolkit.33424.n3.nabble.com/Thumbnailpicker-inside-dojo-dialog-td1988581.html

Short story: I'm using a Thumbnailpicker inside a Dojo dialog, but for some odd reason the "next image button" does not seem to be working (I click on it, but it does nothing). However I found out that, changing the following line in dojox.fx.smoothScroll, fixes the problem:

var _2=dojo[(dojo.isIE?"isObject":"isFunction")](_1["win"].scrollTo),_3={x:_1.target.x,y:_1.target.y}; 
if(!_2){ 
var _4=dojo.position(_1.win); 
_3.x-=_4.x; 
_3.y-=_4.y; 
} 

To:

var _2=dojo[(dojo.isIE?"isObject":"isFunction")](_1["win"].scrollTo),_3={x:_1.target.x,y:_1.target.y}; 
if(_2){ 
var _4=dojo.position(_1.win); 
_3.x-=_4.x; 
_3.y-=_4.y; 
} 

So far the only problem I'm having (I'm not sure if it has to do with the change I've done in dojox.fx.smoothScroll) Is that, in Opera and Chromium, If I Scroll to the end of the thumbnailpicker, once I close the dialog, everytime I Open it again, the Scroll List is reseted to the begining of the list (but not the buttons, which makes the widget unusable) I've only tryed with reset() and init() for fixing it, but I have no luck.

If someone points me where to download the entire dojo project uncompressed, I could give it a second try.

Change History (3)

comment:1 Changed 9 years ago by Adam Peller

Component: GeneralDojox
Description: modified (diff)
Owner: changed from anonymous to dante

aren't those two snippets identical?

as mentioned on the thread, sources are available here http://dojotoolkit.org/download#sdk

comment:2 Changed 8 years ago by mpasternak

YaPeL, any progress on this bug, any chances you could post a solution? I also hit it, and it's not nice.

comment:3 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.