Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11975 closed defect (fixed)

dijit.form.Select is too tall in high contrast mode under Claro theme

Reported by: zhuxw Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit - Form Version: 1.5
Keywords: Select high-contrast dijitArrowButtonInner Cc:
Blocked By: Blocking:

Description (last modified by bill)

When using high contrast mode, the dijit.form.Select widget becomes much taller than usual.

Cause: The "display: block" in claro theme file has overridden the "display: none" fix in dijit.css for a11y issues:

dijit/themes/dijit.css line 163

.dijit_a11y div.dijitArrowButtonInner
...
{
  display: none //This is correct!
}

dijit/themes/claro/form/select.css line 49:

.claro .dijitSelect .dijitArrowButton .dijitArrowButtonInner{
  ...
  display: block //This overrides the previous one!
}

Attachments (1)

Select-high-contrast.png (10.5 KB) - added by zhuxw 9 years ago.
dijit.form.Select in high contrast mode

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by zhuxw

Attachment: Select-high-contrast.png added

dijit.form.Select in high contrast mode

comment:1 Changed 9 years ago by bill

Component: GeneralDijit
Description: modified (diff)
Milestone: tbd1.6
Owner: changed from anonymous to bill
Status: newassigned

Good catch, my tests show that display:block isn't needed at all anyway, so I'll remove it.

comment:2 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [23234]) Remove unneeded display:block that was making Select too tall in high contrast mode, fixes #11975.

comment:3 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.