Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11970 closed defect (fixed)

ValidationTextBox: change Warning state to Incomplete

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.6
Component: Dijit - Form Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description


Change History (7)

comment:1 Changed 9 years ago by bill

Thanks. This will allow Form to easily compute Form.state from it's children's states, and to use child.watch() to detect changes in the children's states.

The other thing is that the comment (in ValidationTextBox.js, Select.js) suggests that state == "Normal" when the widget is not in an error / incomplete state, probably you just want to update that to say that it's "". (In any case the comment should be consistent w/the behavior.):

// state: [readonly] String
//		Shows current state (ie, validation result) of input (Normal, Warning, or Error)
state: "",

comment:2 Changed 9 years ago by Douglas Hays

Milestone: tbd1.6
Status: newassigned

comment:3 Changed 9 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [23241]) Fixes #11970. Add Incomplete state support for partially valid textbox values, and changed affected automated tests.

comment:4 Changed 9 years ago by bill

(In [23242]) Fix test to account for new Incomplete state, refs #11970, #10431.

comment:5 Changed 9 years ago by bill

(In [23243]) Make Form take advantage of "Incomplete" / "Error" / "" form widget state changes to recompute state of Form itself.

Since each child widget keeps track of it's state there's no need for the _invalidWidgets array in Form anymore; I think performance is OK without it.

Refs #11970, #11251 !strict.

comment:6 Changed 9 years ago by bill

(In [23743]) Update comment, refs #11970.

comment:7 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.