Opened 10 years ago
Closed 10 years ago
#11948 closed defect (fixed)
[regression] 100%x100% BorderContainer in Claro has scrollbars
Reported by: | Adam Peller | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 1.5 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description
The 1px border introduced in Claro causes scrollbars for he one extra pixel when the BorderContainer? is set to take over the entire window.
Change History (7)
comment:1 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 10 years ago by
Milestone: | tbd → 1.6 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
Unfortunately, the child selector BODY > .dijitBorderContainer
won't work on IE6, so this solution won't work. It will presumably remove all borders on IE6, making the behavior inconsistent with other browsers.
Also, all claro rules need to have .claro in the selector, and !important isn't needed. Probably you thought you needed !important because you forgot .claro.
comment:3 Changed 10 years ago by
[23180] causes a test failure in BorderContainer_full. Be sure to run the automated tests before fixing this issue.
comment:4 Changed 10 years ago by
The link provided - indicates page can not be found. Is there another file to review and reproduce and/or send screen shot of error occurring in IE6. We are also looking into it.
comment:5 Changed 10 years ago by
comment:6 Changed 10 years ago by
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [23284]) Remove border on BorderContainer. It's undesirable on both full viewport BorderContainers and on BorderContainers nested inside of other BorderContainers. Apps can specify a border explicitly if they want one.
Also removed padding (a.k.a "outer gutters") on BorderContainers nested inside of other BorderContainers since the nesting of BorderContainers should be transparent to a user. See dijit/tests/layout/test_Gui.html for testing, although it doesn't look very good in claro since claro doesn't support tabstrip for TabContainers.
Fixes #11948.
(In [23180]) Introduce override for border:0 on 100%x100% BorderContainers?. Had to use \!important hack. Fixes #11948