Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#11938 closed defect (fixed)

[patch][ccla]dojo.gfx placement offscreen should be vertical

Reported by: Adam Peller Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5.1
Component: DojoX GFX Version: 1.5
Keywords: bidi Cc:
Blocked By: Blocking:

Description

placing at negative left offsets is a problem for rtl/bidi usage. Should use negative top offsets instead. I thought this edit had been applied long ago, perhaps to a different part of gfx?

Attachments (2)

barchart.html (1.0 KB) - added by Adam Peller 9 years ago.
test case from Brian Ragusa (IBM, CCLA)
gfx-rtl.patch (1.6 KB) - added by Adam Peller 9 years ago.
use negative top offsets instead of negative left, dojo.create, and remove superfluous div=null assignment

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by Adam Peller

Can the has/add/removeClass definitions now be replaced with the ones in dojo base?

Changed 9 years ago by Adam Peller

Attachment: barchart.html added

test case from Brian Ragusa (IBM, CCLA)

Changed 9 years ago by Adam Peller

Attachment: gfx-rtl.patch added

use negative top offsets instead of negative left, dojo.create, and remove superfluous div=null assignment

comment:2 Changed 9 years ago by Adam Peller

(In [23309]) Use top negative offset instead of left to fix bidi problem for 1.5 branch. Refs #11938

comment:3 Changed 9 years ago by Adam Peller

Milestone: 1.61.5.1

comment:4 Changed 8 years ago by Eugene Lazutkin

Milestone: 1.5.11.6

comment:5 Changed 8 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [23698]) gfx: rtl/bidi fix for text measurements, thx peller (CLA)!, !strict, fixes #11938.

comment:6 Changed 8 years ago by Adam Peller

Milestone: 1.61.5.1

thanks for checking into trunk. I already checked in a limited fix to 1.5.1 in r23309, so moving the milestone back to 1.5.1, leaving resolution as fixed.

Note: See TracTickets for help on using tickets.