Opened 10 years ago

Closed 10 years ago

#11932 closed defect (fixed)

validationMessages test does not run

Reported by: Katie Vance Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit Version: 1.5
Keywords: FF4 Cc: haysmark
Blocked By: Blocking:

Description

The test /dijit/tests/form/robot/validationMessages does not run because textbox.focusNode.scrollIntoView() is called at the wrong time. It is called on each textbox once before any tests are run. That leaves the very last textbox scrolled into view when the tests start to run. Therefore, when the first test runs, it's texbox is actually not in view. The robot then clicks the title of the browser window instead of the first text box.

The failure can also be seen in Opera.

Attaching the patch.

Attachments (1)

validationMessages.patch (891 bytes) - added by Katie Vance 10 years ago.
Move textbox scrollIntoView inside the testSetup method

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Katie Vance

Attachment: validationMessages.patch added

Move textbox scrollIntoView inside the testSetup method

comment:1 Changed 10 years ago by Katie Vance

Component: GeneralDijit
Owner: changed from anonymous to Douglas Hays

comment:2 Changed 10 years ago by bill

Cc: haysmark added
Summary: FF4: validationMessages test does not runvalidationMessages test does not run

Aha. I'm seeing the same problem on IE8, so it's not limited to FF4 and opera. It might depend on something random like screen size or font setting. I had sent Mark mail thinking it was a robot problem (and maybe there is a robot problem too), but glad you tracked down the main issue and that there's a simple fix.

comment:3 Changed 10 years ago by bill

Milestone: tbd1.6
Owner: changed from Douglas Hays to bill
Status: newassigned

I'll check in.

comment:4 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [23171]) Fix from Katie to call textbox.focusNode.scrollIntoView() at the right time. Seems though like this test would be more stable if it just called focus() for each textbox, rather than calling mouseMove() and mouseClick(). Fixes #11932.

Note: See TracTickets for help on using tickets.