Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1193 closed defect (fixed)

dojo.selection.Selection#length is outdated.

Reported by: mwubben@… Owned by: dylan
Priority: high Milestone:
Component: Collections Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

Working with dojo.selection.Selection, I'm having trouble with the length property. This field is a copy of the length property of the internal selection array, but it's not updated when items are selected or deselected. Instead, you have to force an update with updateSelected().

I'm wondering whether this is a feature or a bug, in case of the latter I'd be more than willing to provide a patch.

Attachments (1)

patch.diff​ (536 bytes) - added by mwubben@… 13 years ago.
SVN diff of the required changes to fix the issue.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by david

I think that's probably a bug (I did the original code).

comment:2 Changed 13 years ago by mwubben@…

Owner: changed from Tom Trenka to guest
Status: new → assigned

Hmm, needed it for a specific outliner application? ;-)

I'll fix it, although it isn't a very high priority right now. I'll be back in a week or two for sure.

comment:3 Changed 13 years ago by dylan

Milestone: → 0.5

Changed 13 years ago by mwubben@…

Attachment: patch.diff​ added

SVN diff of the required changes to fix the issue.

comment:4 Changed 13 years ago by mwubben@…

Owner: changed from guest to dylan
Status: assigned → new

I've attached a SVN diff generated by TextMate? which contains the fix. If this is the wrong format (and it probably is) please let me know what you need.

The patch was written at JotSpot?, who have signed an CCLA and I'm allowed to contribute it to Dojo.

comment:5 Changed 13 years ago by dylan

Status: new → assigned

comment:6 Changed 13 years ago by dylan

Resolution: → fixed
Status: assigned → closed

(In [5365]) fixes #1193, patch from Jot/Mark? Wubben, Selection.js out of date

comment:7 Changed 13 years ago by dylan

Milestone: 0.5 → 0.4
Resolution: fixed
Status: closed → reopened

comment:8 Changed 13 years ago by dylan

Resolution: → fixed
Status: reopened → closed

comment:9 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.