Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11926 closed defect (fixed)

Claro: hovering toolbar buttons causes shift (IE6, IE7)

Reported by: bill Owned by:
Priority: high Milestone: 1.6
Component: Dijit - Form Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

See test_Toolbar.html. Hovering any of the toolbar buttons causes the toolbar to jiggle (i.e. causes all the buttons to the right of the hovered button to move 2px).

Seems like the problem, except for ComboButton, can be fixed just by removing all the special IE6 and IE7 rules from claro/Toolbar.css.

IE7 is currently working except for ComboButton. However, it also seems to work equally well after removing all those special IE7 rules.

Change History (7)

comment:1 Changed 9 years ago by bill

(In [23130]) Remove IE6 and IE7 specific rules that seem to do more harm than good, refs #11926.

comment:2 Changed 9 years ago by bill

(In [23222]) Restore code accidentally removed in [23130], refs #11926

comment:3 Changed 9 years ago by bill

(In [23223]) Simplification, combining identical selectors, refs #11926

comment:4 Changed 9 years ago by bill

Summary: Chrome: hovering toolbar buttons causes shift (IE6, IE7)Claro: hovering toolbar buttons causes shift (IE6, IE7)

Remaining problem is ComboButton, which is tricky due to weird stuff with tables with borders on IE.

comment:5 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [23271]) Fixes for claro's ComboButton in a Toolbar:

  • make border for entire ComboButton appear on hover, to make it clear that it's a single ComboButton rather than two buttons, fixes #12019
  • fix IE horizontal jitter on hover, fixes #11926
  • fix problem on chrome where toolbar shrinks vertically on hover, fixes #11553

This still needs some CSS cleanup/streamlining but it's working.

comment:6 Changed 9 years ago by bill

(In [23273]) Further simplifications for claro's ComboButton in a Toolbar, making it work more like a regular ComboButton, where the arrow is missing it's left border regardless of which side of the ComboButton is hovered, refs #12019.

Also, fixed corners so that only the outer corners (left side of button, right side of arrow) are rounded.

Finally, simplified fix for IE horizontal jitter on hover, main problem was that there was padding on the <table> node, refs #11926.

comment:7 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.