Opened 9 years ago

Closed 8 years ago

#11915 closed defect (fixed)

Adding new item to XmlStore is failing as there is wrong call in newItem method.

Reported by: p_durga Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.7
Component: DojoX Data Version: 1.4.3
Keywords: XmlStore Cc:
Blocked By: Blocking:

Description

When we add a single item to an XmlStore? it is failing because of wrong call, the newItem is calling setValues instead of setValue. As it is calling setValues in setValues method when trying to get the length it is failing and the item is not getting added.

Once an item is added to the store if you add one more item it is not getting added and the Model is not getting updated with the new one.

var values = this.getValues(parentInfo.parent,parentInfo.attribute); if(values && values.length > 0){

var tempValues = values.slice(0, values.length); if(values.length === 1){

pInfo.oldValue = values[0];

}else{

pInfo.oldValue = values.slice(0, values.length);

} tempValues.push(item); this.setValues(parentInfo.parent, parentInfo.attribute, tempValues); pInfo.newValue = this.getValues(parentInfo.parent, parentInfo.attribute);

}else{

this.setValues(parentInfo.parent, parentInfo.attribute, item); pInfo.newValue = item;

}

Change History (4)

comment:1 Changed 9 years ago by Jared Jurkiewicz

Milestone: tbdfuture

Haven't had time to investigate this, marking future for now.

comment:2 Changed 8 years ago by Jared Jurkiewicz

Milestone: future1.7

comment:3 Changed 8 years ago by Jared Jurkiewicz

I think I know the change to make here based on the description

comment:4 Changed 8 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [25694]) Trying to fix the set call. fixes #11915

Note: See TracTickets for help on using tickets.