Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11911 closed task (fixed)

convert dojox.math to AMD format

Reported by: ben hockey Owned by: ben hockey
Priority: high Milestone: 1.6
Component: Dojox Version: 1.5
Keywords: Cc: Eugene Lazutkin
Blocked By: Blocking:

Description

this ticket is to track changes made to dojox.math to convert to AMD format.

a number of other dojox namespaces depend on parts of dojox.math

  • dojox.calc
  • dojox.color
  • dojox.drawing
  • dojox.encoding

and will need to be considered when making changes that effect backwards compatibility

Change History (6)

comment:1 Changed 9 years ago by ben hockey

(In [23089]) converted dojox.math to AMD format. all tests passed in dojox.math and in any dojox module with dependencies on dojox.math. !strict. refs #11911

comment:2 Changed 9 years ago by ben hockey

some notes:

  • no tests were found for dojox.math.curves or dojox.math.matrix
  • some dependencies in the code for dojo base were removed by refactoring code that had previously used dojo.declare
  • further dependencies can be removed if some dojo.mixin calls are not needed - see dojox.math.curves for an example
  • almost all of the remaining dependencies on dojo base can be removed if dojox.math.* globals are not needed

the "simple" (completely backwards compatible) conversion for dojox.math is complete but leaving this ticket open to discuss options for further conversion. for example:

  • remove dependency on dojo base where possible
  • remove globals

comment:3 Changed 9 years ago by ben hockey

(In [23100]) make dojox.math conform to what is expected by the AMD build transform. !strict. refs #11911

comment:4 Changed 9 years ago by ben hockey

Resolution: fixed
Status: newclosed

(In [23133]) changed dojox.math to follow the simple AMD transform pattern applied to dojo and dijit. it seems that it might be premature to try and refactor the code more than this.

effectively, this commit rolled back dojox.math to before r23089 and manually converted to AMD in a way similar to the automatic conversion done to dojo and dijit. !strict. fixes #11911

comment:5 Changed 9 years ago by ben hockey

(In [23134]) missed this one in r23133 !strict. fixes #11911

comment:6 Changed 9 years ago by ben hockey

Milestone: tbd1.6
Note: See TracTickets for help on using tickets.