Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11883 closed defect (fixed)

Regressions in test_Select

Reported by: haysmark Owned by: Rawld Gill
Priority: high Milestone: 1.6
Component: Loader Version: 1.5
Keywords: Cc:
Blocked By: Blocking:

Description

I get two regressions in test_Select with the new loader:

  1. In the checkout in IE6 only, I get an alert box with an error, "Stack Overflow at line: 0". After you close the error, the test seems to otherwise work. This halts the automated tests until you intervene and press OK. See:

First appears: http://archive.dojotoolkit.org/dojo-2010-10-21/checkout/dijit/tests/form/test_Select.html

Still broken: http://archive.dojotoolkit.org/dojo-2010-10-25/checkout/dijit/tests/form/test_Select.html

  1. In all browsers, in the nightly build but not in the checkout. I get the error, "dojo.i18n is not defined".

First appears: http://archive.dojotoolkit.org/dojo-2010-10-24/dojotoolkit/dijit/tests/form/test_Select.html

Still works in checkout(?): http://archive.dojotoolkit.org/dojo-2010-10-24/checkout/dijit/tests/form/test_Select.html

In previous releases, when a module called dojo.requireLocalization(), the loader automatically loaded dojo.i18n. Do we now require the user manually specify "dojo/i18n"?

Change History (8)

comment:1 Changed 9 years ago by haysmark

Cross reference #11869.

comment:2 Changed 9 years ago by haysmark

Owner: changed from anonymous to Rawld Gill

Here is a smaller test case for the first regression: (put in dijit/form/Select)

define("dijit/form/Select", ["dojo", "dijit", 
// broken order; generates Stack Overflow in IE6
"dijit/form/_FormSelectWidget", "dijit/_HasDropDown",
// this order works???
// "dijit/_HasDropDown", "dijit/form/_FormSelectWidget",
], function(dojo, dijit) {
return {};
});

dijit/_HasDropDown loads some dependencies for dijit/form/_FormSelectWidget, so it seems the new loader uses too much recursion.

comment:3 Changed 9 years ago by Rawld Gill

Status: newassigned

comment:4 Changed 9 years ago by Rawld Gill

I suspect this problem is related to the issue fixed in [23059].

Please rebuild with the repaired build utility and reattempt on IE6 (I would do this, but I don't have and IE6 environment available presently).

comment:5 Changed 9 years ago by haysmark

test_Select still shows the Stack Overflow error in [23064] in IE6.

comment:6 Changed 9 years ago by bill

Milestone: tbd1.6

It's loading for me on IE6 now, probably fixed by [23073], should we close this?

comment:7 Changed 9 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

Fixed in [23074]

comment:8 Changed 9 years ago by bill

Component: GeneralLoader
Note: See TracTickets for help on using tickets.